ISISComputingGroup / ISISComputingGroup/DataStreaming

`kafka_dae_control`: periods: attempt to prevent invalid configurations

Aperta
#103 5 commenti 0 reazioni 0 assegnatari Vedi su GitHub
good first issue
Lingua principale
Nessun dato sulla lingua
Stelle
0
Fork
0
Metriche di merge delle PR
Nessuna PR unita negli ultimi 30g

Descrizione

In `COMPUTER` control mode:
- If I try to set `PERIODS:SP` to larger than `NUMPERIODS:MAX`, I should get an error.
- If I'm in period `N` and I try to change `NUMPERIODS:MAX` to less than `N`, put back to period 0 (user period 1)?
- I probably shouldn't be allowed to set `NUMPERIODS:MAX` to zero
- If I was previously in period N and this was done by `EXTERNAL` or `LOOKUP` control mode, then when I change to `COMPUTER` control mode this should be verified against `NUMPERIODS:MAX` and set back to something valid if `N` is larger than `NUMPERIODS:MAX`.
- As per discussion below, `NOT_USED` is not a real control mode (it was meant to say that this bit-pattern does not correspond to anything in the hardware). Remove references to `NOT_USED` in our code.

Guida per i contributori

Nessuna guida per i contributori indicizzata per questo repository

Direzione di ricerca

Start at the `kafka_dae_control` entry point named in the issue and trace how control modes, `PERIODS:SP`, and `NUMPERIODS:MAX` are handled. Verify the COMPUTER-mode bounds, period reset behavior, validation when switching from EXTERNAL or LOOKUP, and removal of NOT_USED references; add or run the relevant tests to confirm each case.

Scritto dal modello di indicizzazione a partire dal testo della issue.

Valutazione

Stack tecnologico
kafka
Ambito
embedded-iot
Tipo di issue
Bug
Difficoltà
4/5
Tempo stimato
3-5 giorni
Stato di attività
Tranquilla
Chiarezza
Da chiarire
Idoneità per principianti
45/100

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.