HelloZeroNet / HelloZeroNet/ZeroNet

[Android] Disable console logging if another logger is already hooked

Aperta
#2,139 14 commenti 1 reazione 0 assegnatari Vedi su GitHub
bug
Lingua principale
JavaScript
Stelle
18.8k
Fork
2.3k
Metriche di merge delle PR
Nessuna PR unita negli ultimi 30g

Descrizione

### Step 1: Please describe your environment

* ZeroNet version: 4163
* Operating system: Android 9 / LOS 16
* Web browser: Firefox Klar Android
* Tor status: not available
* Opened port: no
* Special configuration: android

### Step 2: Describe the problem:

#### Steps to reproduce:

1. Launch the zeronet android app (python3 branch) without the patch
2. Watch it crash in the logs

#### Observed Results:

* The log keeps spamming, as the kivy logger repeats the zeronet logger which then repeats the kivy logger, causing a log overflow

#### Expected Results:

* It should detect this other logger and don't register it's own

#### Current workarround:

I'm applying this patch:

```patch
diff --git a/src/main.py b/src/main.py
index dfc32cc9..9f21ef2c 100644
--- a/src/main.py
+++ b/src/main.py
@@ -52,7 +52,7 @@ if config.action == "main":
print("Error starting browser: %s" % err)
sys.exit()

-config.initLogging()
+config.initLogging(console_logging=False)


# Debug dependent configuration
```

Instead this variable could be dynamically set, based on whether or not another logger is registered

Guida per i contributori

Nessuna guida per i contributori indicizzata per questo repository

Valutazione

Questa issue non è ancora stata valutata.

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.