HelloZeroNet / HelloZeroNet/ZeroNet

[Android] Disable console logging if another logger is already hooked

Open
#2,139 14 comments 1 reaction 0 assignees View on GitHub
bug
Dominant language
JavaScript
Stars
18.8k
Forks
2.3k
PR merge metrics
No merged PRs in 30d

Description

### Step 1: Please describe your environment

* ZeroNet version: 4163
* Operating system: Android 9 / LOS 16
* Web browser: Firefox Klar Android
* Tor status: not available
* Opened port: no
* Special configuration: android

### Step 2: Describe the problem:

#### Steps to reproduce:

1. Launch the zeronet android app (python3 branch) without the patch
2. Watch it crash in the logs

#### Observed Results:

* The log keeps spamming, as the kivy logger repeats the zeronet logger which then repeats the kivy logger, causing a log overflow

#### Expected Results:

* It should detect this other logger and don't register it's own

#### Current workarround:

I'm applying this patch:

```patch
diff --git a/src/main.py b/src/main.py
index dfc32cc9..9f21ef2c 100644
--- a/src/main.py
+++ b/src/main.py
@@ -52,7 +52,7 @@ if config.action == "main":
print("Error starting browser: %s" % err)
sys.exit()

-config.initLogging()
+config.initLogging(console_logging=False)


# Debug dependent configuration
```

Instead this variable could be dynamically set, based on whether or not another logger is registered

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.