HelloZeroNet / HelloZeroNet/ZeroHello

Handle the case, when a post with no title is displayed in the feed.

Ouverte
#96 0 commentaires 3 réactions 0 personnes assignées Voir sur GitHub
Langage dominant
JavaScript
Étoiles
73
Forks
69
Métriques de merge des PR
Aucune PR mergée en 30 j

Description

It is possible that the title field accidentaly isn't set or intentionaly left empty in the site DB. In that case, we have the following in the feed:

![untitled-1](https://user-images.githubusercontent.com/1287690/44947166-43de3000-ae33-11e8-80bd-2aa2232a3ef0.png)

It looks ugly, and we also cannot navigate directly to the post, since the title is the link.

The problem can be solved on the site's side, if the correct SQL query is used. For example:

```
@follow.addFeed("Posts", "
SELECT
post_id AS event_uri,
'post' AS type,
date_published AS date_added,
IFNULL(NULLIF(title, ''), '(untitled)') AS title,
body AS body,
'?Post:' || post_id AS url
FROM post", true)

```

In that example, `IFNULL(NULLIF(title, ''), '(untitled)')` replaces both NULL and the empty string with "(untitled)", so we have in the feed:

![untitled-2](https://user-images.githubusercontent.com/1287690/44947169-4e002e80-ae33-11e8-93cb-63cf7eef26d8.png)

But I believe it is better to handle that case on the ZeroHello side. It will be applied to any site, and it also makes possible to localize the '(untitled)' string in a uniform way.

Guide de contribution

Aucun guide de contribution indexé pour ce dépôt

Évaluation

Cette issue n'a pas encore été évaluée.

Recevez les nouvelles issues par e-mail

Un résumé court des issues GitHub adaptées aux débutants.