HelloZeroNet / HelloZeroNet/ZeroHello

Handle the case, when a post with no title is displayed in the feed.

Offen
#96 0 Kommentare 3 Reaktionen 0 zugewiesene Personen Auf GitHub ansehen
Vorherrschende Sprache
JavaScript
Sterne
73
Forks
69
PR-Merge-Kennzahlen
Keine gemergten PRs in 30 T.

Beschreibung

It is possible that the title field accidentaly isn't set or intentionaly left empty in the site DB. In that case, we have the following in the feed:

![untitled-1](https://user-images.githubusercontent.com/1287690/44947166-43de3000-ae33-11e8-80bd-2aa2232a3ef0.png)

It looks ugly, and we also cannot navigate directly to the post, since the title is the link.

The problem can be solved on the site's side, if the correct SQL query is used. For example:

```
@follow.addFeed("Posts", "
SELECT
post_id AS event_uri,
'post' AS type,
date_published AS date_added,
IFNULL(NULLIF(title, ''), '(untitled)') AS title,
body AS body,
'?Post:' || post_id AS url
FROM post", true)

```

In that example, `IFNULL(NULLIF(title, ''), '(untitled)')` replaces both NULL and the empty string with "(untitled)", so we have in the feed:

![untitled-2](https://user-images.githubusercontent.com/1287690/44947169-4e002e80-ae33-11e8-93cb-63cf7eef26d8.png)

But I believe it is better to handle that case on the ZeroHello side. It will be applied to any site, and it also makes possible to localize the '(untitled)' string in a uniform way.

Beitragsleitfaden

Für dieses Repository ist kein Beitragsleitfaden indexiert

Rechercherichtung

Start by locating the ZeroHello feed rendering and how post titles become links. Check how missing and empty titles are displayed, then make both cases show a localized untitled label while keeping the post navigable; verify the resulting feed behavior for posts without titles.

Vom Indexierungsmodell aus dem Issue-Text verfasst.

Bewertung

Tech-Stack
javascript
Bereich
frontend
Issue-Typ
Bug
Schwierigkeit
3/5
Geschätzter Aufwand
1-2 Tage
Aktivitätsstatus
Veraltet
Klarheit
Größtenteils klar
Anfängerfreundlichkeit
45/100

Neue Issues direkt in Ihr Postfach

Eine kurze Übersicht über anfängerfreundliche GitHub-Issues.