GraphiteEditor / GraphiteEditor/Graphite

Dependency uses nightly toolchain even when building app with stable toolchain

Ouverte
#4,229 10 commentaires 0 réactions 0 personnes assignées Voir sur GitHub
Langage dominant
Rust
Étoiles
27.2k
Forks
1.3k
Merge moyen
20 h 5 min
PR mergées (30 j)
57

Description

Singe the topic came up in #4227 of an immanent stable release, I had another look at the Arch Linux packaging (currently the Git HEAD based VCS package in the AUR, but with an eye to making an official stable package when the time comes). I tried building it with a stable Rust toolchain but it fails:

```
error: failed to run custom build command for `raster-nodes-shaders v0.1.0 (/build/graphite-editor-git/src/graphite-editor-git/node-graph/nodes/raster/shaders)`

Caused by:
process didn't exit successfully: `/build/graphite-editor-git/src/graphite-editor-git/target/release/build/raster-nodes-shaders-0590a2ab379ae769/build-script-build` (exit status: 1)
--- stdout
cargo:rerun-if-env-changed=RASTER_NODES_SHADER_PATH
cargo:rerun-if-env-changed=RUST_GPU_PATH_OVERRIDE
cargo:rerun-if-env-changed=RUSTC_CODEGEN_SPIRV_PATH

--- stderr
[2026-06-12T09:33:05Z INFO cargo_gpu_install::install] cache directory is '/build/.cache/rust-gpu'
[2026-06-12T09:33:05Z DEBUG cargo_gpu_install::spirv_source] Running `cargo metadata` on `/build/graphite-editor-git/src/graphite-editor-git/node-graph/nodes/raster/shaders/entrypoint`
[2026-06-12T09:33:05Z DEBUG cargo_gpu_install::spirv_source] Parsed `rust-gpu` source and version: CratesIO(Version { major: 0, minor: 10, patch: 0, pre: Prerelease("alpha.1") })
[2026-06-12T09:33:05Z DEBUG cargo_gpu_install::spirv_source] Parsed `SpirvSource` from crate `/build/graphite-editor-git/src/graphite-editor-git/node-graph/nodes/raster/shaders/entrypoint`: CratesIO(Version { major: 0, minor: 10, patch: 0, pre: Prerelease("alpha.1") })
[2026-06-12T09:33:05Z DEBUG cargo_gpu_install::install] writing `rustc_codegen_spirv_dummy` source files into '/build/.cache/rust-gpu/codegen/0_10_0-alpha_1'
[2026-06-12T09:33:05Z DEBUG cargo_gpu_install::install] resolving toolchain version to use
[2026-06-12T09:33:05Z DEBUG cargo_gpu_install::spirv_source] Running `cargo metadata` on `/build/.cache/rust-gpu/codegen/0_10_0-alpha_1`
[2026-06-12T09:33:09Z DEBUG cargo_gpu_install::spirv_source] Parsing `build.rs` at "/build/.cargo/registry/src/index.crates.io-1949cf8c6b5b557f/rustc_codegen_spirv-0.10.0-alpha.1/build.rs" for the used toolchain
[2026-06-12T09:33:09Z INFO cargo_gpu_install::install] selected toolchain channel `"nightly-2026-04-11"`
[2026-06-12T09:33:09Z DEBUG cargo_gpu_install::install] ensure_toolchain_and_components_exist
Error: ensuring toolchain and components exist

Caused by:
0: Failed to launch cmd `rustup toolchain list -q`
1: No such file or directory (os error 2)
```

I would suggest this needs to get addressed before release so the whole thing can be built with a single stable toolchain, not some pinned nightly if possible. If not possible this needs to be better documented. In that event I would also suggest setting the main project toolchain defaults to match this deep dependency so that the build requirements were clear upfront and the whole thing is built with the same toolchain instead of mixing and matching.

Guide de contribution

Aucun guide de contribution indexé pour ce dépôt

Piste de recherche

Start in node-graph/nodes/raster/shaders and inspect the entrypoint metadata and the rustc_codegen_spirv build.rs logic that selects a toolchain. Reproduce the stable-toolchain build and check the cargo_gpu_install output and rustup invocation. Done means the project builds with one stable toolchain, or the required nightly toolchain is clearly documented and consistently selected.

Rédigé par le modèle d'indexation à partir du texte de l'issue.

Évaluation

Stack technique
rust
Domaine
build-system
Type d'issue
Bug
Difficulté
4/5
Temps estimé
3-5 jours
Activité
Calme
Clarté
Plutôt claire
Accessibilité débutants
48/100

Recevez les nouvelles issues par e-mail

Un résumé court des issues GitHub adaptées aux débutants.