GraphiteEditor / GraphiteEditor/Graphite

Ad-hoc graph introspection instead of Monitor nodes for thumbnails and click targets

Open
#2,044 0 comments 0 reactions 0 assignees View on GitHub
Graphene
Dominant language
Rust
Stars
27.2k
Forks
1.3k
Avg merge
20h 5m
Merged PRs (30d)
57

Description

Latest plans call for removing the *Monitor* node approach of extracting thumbnail data and instead executing the graph to obtain the thumbnail with specific bounds that it prefers, as well as potentially other `Context` values specific to the individual render of the thumbnail (or a user-requested thumbnail render from within the dialog that shows up when expanding a thumbnail into a graph value diagnostics interface).

---

Old issue description when this was titled "Automatic monitor node insertion":

In order to display thumbnails for every wire, a Monitor node should be placed at outputs during compilation. The number of monitor nodes should be minimized to avoid redundant clones as data flows through the graph. The outputs would be selected based on which thumbnails should be rendered, both in the node graph UI and layer panel. This would also improve #2028 and getting artboard translations in the [Clear Artboards PR](https://github.com/GraphiteEditor/Graphite/pull/2015).

Monitor nodes will be the standard way of getting data from the node graph, as opposed to the render output. This is because the render output does not include all data in the node graph due to destructive operations like rasterize or boolean operations. We currently work around this by redundantly storing the upstream graphic group for vector data created by a boolean operation, but this is not ideal. (This is something that is still currently being discussed)

https://discord.com/channels/731730685944922173/731738914812854303/1291860544604602439
https://discord.com/channels/731730685944922173/731738914812854303/1291830448195899527

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.