GraphiteEditor / GraphiteEditor/Graphite

Upgrade to Svelte 5 and remove slow manual component event delegation

Aperta
#1,877 1 commento 1 reazione 1 assegnatario Rivendicata da @Keavon Vedi su GitHub
Performance Web
Lingua principale
Rust
Stelle
27.2k
Fork
1.3k
Merge medio
20h 5m
PR unite (30g)
57

Descrizione

`LayoutRow.svelte` and `LayoutCol.svelte` each have to manually [delegate events](https://github.com/sveltejs/svelte/issues/2837) and we take the ugly approach of just naming every event for delegation. But as @adamgerhant and I just discovered when debugging a performance issue with creating and destroying a bunch of layers in the Layers panel, it turns out Svelte is creating and destroying an event handler for each and every one of those delegated events, even when nearly all are unused. Removing these quadruples the performance for creating/removing all those layers.

Svelte 5 [allows components to delegate events](https://svelte-5-preview.vercel.app/docs/old-vs-new#forwarding-events). We should aim to upgrade to Svelte 5 and update how those components are doing their event delegation. (Side note: can we also delegate other attributes like `class` and `style` to avoid the hacky way we have many components do that presently?) This should provide a significant frontend performance improvement for all components that utilize LayoutRow and LayoutCol.

Guida per i contributori

Nessuna guida per i contributori indicizzata per questo repository

Valutazione

Questa issue non è ancora stata valutata.

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.