GraphiteEditor / GraphiteEditor/Graphite

Upgrade to Svelte 5 and remove slow manual component event delegation

Abierto
#1,877 1 comentario 1 reacción 1 asignado Reclamado por @Keavon Ver en GitHub
Performance Web
Lenguaje dominante
Rust
Estrellas
27.2k
Forks
1.3k
Merge medio
20 h 5 min
PR fusionados (30 d)
57

Descripción

`LayoutRow.svelte` and `LayoutCol.svelte` each have to manually [delegate events](https://github.com/sveltejs/svelte/issues/2837) and we take the ugly approach of just naming every event for delegation. But as @adamgerhant and I just discovered when debugging a performance issue with creating and destroying a bunch of layers in the Layers panel, it turns out Svelte is creating and destroying an event handler for each and every one of those delegated events, even when nearly all are unused. Removing these quadruples the performance for creating/removing all those layers.

Svelte 5 [allows components to delegate events](https://svelte-5-preview.vercel.app/docs/old-vs-new#forwarding-events). We should aim to upgrade to Svelte 5 and update how those components are doing their event delegation. (Side note: can we also delegate other attributes like `class` and `style` to avoid the hacky way we have many components do that presently?) This should provide a significant frontend performance improvement for all components that utilize LayoutRow and LayoutCol.

Guía de contribución

No hay ninguna guía de contribución indexada para este repositorio

Evaluación

Este issue todavía no se ha evaluado.

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.