GoogleCloudPlatform / GoogleCloudPlatform/opentelemetry-operations-java

getAttribute fetches data from http://metadata.google.internal/computeMetadata/v1/ without a timeout

Aperta
#421 0 commenti 0 reazioni 0 assegnatari Vedi su GitHub
Lingua principale
Java
Stelle
78
Fork
39
Merge medio
14m
PR unite (30g)
1

Descrizione

`detectSupportedPlatform` tries to fetch data from a URL. This can take a long time on hosts that do not have access to that host:

1. `detectSupportedPlatform` calls `isRunningOnGcp()`: https://github.com/GoogleCloudPlatform/opentelemetry-operations-java/blob/ee8c19280e6970ce8902f043bc7a4592acc4a091/detectors/resources-support/src/main/java/com/google/cloud/opentelemetry/detection/GCPPlatformDetector.java#L45
2. `isRunningOnGcp()` calls `GcpMetadataConfig#getProjectId()`
3. `GcpMetadataConfig#getProjectId()` calls `getAttribute(String)`
4. `getAttribute` tries to fetch data from http://metadata.google.internal/computeMetadata/v1/

The latter can potentially block for a long time. Would it maybe be better to add a timeout to that call?

Background: https://github.com/googleapis/java-spanner-jdbc/issues/2250

Guida per i contributori

Apri la guida per i contributori

Valutazione

Questa issue non è ancora stata valutata.

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.