GoogleCloudPlatform / GoogleCloudPlatform/opentelemetry-operations-java
getAttribute fetches data from http://metadata.google.internal/computeMetadata/v1/ without a timeout
- Dominant language
- Java
- Stars
- 78
- Forks
- 39
- Avg merge
- 14m
- Merged PRs (30d)
- 1
Description
`detectSupportedPlatform` tries to fetch data from a URL. This can take a long time on hosts that do not have access to that host:
1. `detectSupportedPlatform` calls `isRunningOnGcp()`: https://github.com/GoogleCloudPlatform/opentelemetry-operations-java/blob/ee8c19280e6970ce8902f043bc7a4592acc4a091/detectors/resources-support/src/main/java/com/google/cloud/opentelemetry/detection/GCPPlatformDetector.java#L45
2. `isRunningOnGcp()` calls `GcpMetadataConfig#getProjectId()`
3. `GcpMetadataConfig#getProjectId()` calls `getAttribute(String)`
4. `getAttribute` tries to fetch data from http://metadata.google.internal/computeMetadata/v1/
The latter can potentially block for a long time. Would it maybe be better to add a timeout to that call?
Background: https://github.com/googleapis/java-spanner-jdbc/issues/2250
Contributor guide
Research direction
Start with detectors/resources-support/src/main/java/com/google/cloud/opentelemetry/detection/GCPPlatformDetector.java at detectSupportedPlatform, then trace isRunningOnGcp(), GcpMetadataConfig#getProjectId(), and getAttribute(String). Check the existing detector tests, if present, and verify that probing metadata on an unavailable host is bounded by a timeout without breaking GCP detection.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- java
- Domain
- cloud
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 38/100