GoogleCloudPlatform / GoogleCloudPlatform/opentelemetry-operations-java

getAttribute fetches data from http://metadata.google.internal/computeMetadata/v1/ without a timeout

Open
#421 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
Java
Stars
78
Forks
39
Avg merge
14m
Merged PRs (30d)
1

Description

`detectSupportedPlatform` tries to fetch data from a URL. This can take a long time on hosts that do not have access to that host:

1. `detectSupportedPlatform` calls `isRunningOnGcp()`: https://github.com/GoogleCloudPlatform/opentelemetry-operations-java/blob/ee8c19280e6970ce8902f043bc7a4592acc4a091/detectors/resources-support/src/main/java/com/google/cloud/opentelemetry/detection/GCPPlatformDetector.java#L45
2. `isRunningOnGcp()` calls `GcpMetadataConfig#getProjectId()`
3. `GcpMetadataConfig#getProjectId()` calls `getAttribute(String)`
4. `getAttribute` tries to fetch data from http://metadata.google.internal/computeMetadata/v1/

The latter can potentially block for a long time. Would it maybe be better to add a timeout to that call?

Background: https://github.com/googleapis/java-spanner-jdbc/issues/2250

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.