GoogleCloudPlatform / GoogleCloudPlatform/cloud-sql-nodejs-connector
Improve caching of Instance configs
Aperta
priority: p2
type: feature request
- Lingua principale
- TypeScript
- Stelle
- 97
- Fork
- 16
- Merge medio
- 4g 16h
- PR unite (30g)
- 4
Descrizione
Currently we cache instance connection info by `instanceConnectionName` and error out if the iam authn flag switches between consecutive connect calls. We should update the hash key (instanceConnectionName+iam authn) for how we cache our configs so that we can handle support for flag switches without needing to error.
https://github.com/GoogleCloudPlatform/cloud-sql-nodejs-connector/blob/00a6eae6a18aed0cd1e62d31d46e61eb0c13c7e8/src/connector.ts#L76-L79
Guida per i contributori
Apri la guida per i contributori
Valutazione
Questa issue non è ancora stata valutata.