GoogleCloudPlatform / GoogleCloudPlatform/cloud-sql-nodejs-connector
Improve caching of Instance configs
Abierto
priority: p2
type: feature request
- Lenguaje dominante
- TypeScript
- Estrellas
- 97
- Forks
- 16
- Merge medio
- 4 d 16 h
- PR fusionados (30 d)
- 4
Descripción
Currently we cache instance connection info by `instanceConnectionName` and error out if the iam authn flag switches between consecutive connect calls. We should update the hash key (instanceConnectionName+iam authn) for how we cache our configs so that we can handle support for flag switches without needing to error.
https://github.com/GoogleCloudPlatform/cloud-sql-nodejs-connector/blob/00a6eae6a18aed0cd1e62d31d46e61eb0c13c7e8/src/connector.ts#L76-L79
Guía de contribución
Evaluación
Este issue todavía no se ha evaluado.