GoogleCloudPlatform / GoogleCloudPlatform/cloud-sql-nodejs-connector
Improve caching of Instance configs
Open
priority: p2
type: feature request
- Dominant language
- TypeScript
- Stars
- 97
- Forks
- 16
- Avg merge
- 4d 16h
- Merged PRs (30d)
- 4
Description
Currently we cache instance connection info by `instanceConnectionName` and error out if the iam authn flag switches between consecutive connect calls. We should update the hash key (instanceConnectionName+iam authn) for how we cache our configs so that we can handle support for flag switches without needing to error.
https://github.com/GoogleCloudPlatform/cloud-sql-nodejs-connector/blob/00a6eae6a18aed0cd1e62d31d46e61eb0c13c7e8/src/connector.ts#L76-L79
Contributor guide
Assessment
This issue has not been assessed yet.