GoogleCloudPlatform / GoogleCloudPlatform/cloud-profiler-python

Wall profile collection error due to line number being None on Python 3.10

Đang mở
#124 2 bình luận 1 reaction 1 người được giao Được @aabmass nhận Xem trên GitHub
Ngôn ngữ chính
Python
Star
32
Fork
35
Chỉ số merge pull request
Không có pull request nào được merge trong 30 ngày

Mô tả

Hi, we recently upgraded to Python 3.10 (from Python 3.9) in our service using cloud-profiler-python and are seeing the following error repeatedly in our logs:

```
INFO - warning: Failed to collect and upload profile whose profile type is WALL: Traceback (most recent call last):
INFO - warning: File "/home/appuser/.local/lib/python3.10/site-packages/googlecloudprofiler/client.py", line 293, in _collect_and_upload_profile
INFO - warning: profile_bytes = self._profilers[profile_type].profile(duration_ns)
INFO - warning: File "/home/appuser/.local/lib/python3.10/site-packages/googlecloudprofiler/pythonprofiler.py", line 148, in profile
INFO - warning: return self._serialize_and_clear_traces(duration_ns)
INFO - warning: File "/home/appuser/.local/lib/python3.10/site-packages/googlecloudprofiler/pythonprofiler.py", line 243, in _serialize_and_clear_traces
INFO - warning: profile_builder.populate_profile(self._traces, self._profile_type,
INFO - warning: File "/home/appuser/.local/lib/python3.10/site-packages/googlecloudprofiler/builder.py", line 72, in populate_profile
INFO - warning: location_id = self._location_id(func_id, frame[2])
INFO - warning: File "/home/appuser/.local/lib/python3.10/site-packages/googlecloudprofiler/builder.py", line 131, in _location_id
INFO - warning: line.line = line_number
```

After digging into it, the problem appears to be that the line number in the frame is `None`, which is described in [this issue](https://github.com/python/cpython/issues/94485). The fix appears to have been backported to Python 3.11 but not 3.10, based on the issue comments.

I'm guessing the trace just needs to be discarded somehow if there's no line number but am not sure what the best way to handle this is.

Fortunately, it appears we are still collecting CPU and WALL profiles, but the repeated error messages are annoying.

Hướng dẫn đóng góp

Mở hướng dẫn đóng góp

Đánh giá

Issue này chưa được đánh giá.

Nhận issue mới trong hộp thư của bạn

Bản tóm tắt ngắn những issue GitHub phù hợp với người mới.