GoogleCloudPlatform / GoogleCloudPlatform/cloud-opensource-java

Dashboard and Linkage Checker to take option to resolve dependency graphs with Gradle's way

オープン
#2,007 コメント 0 件 リアクション 0 件 担当者 0 名 GitHub で見る
enhancement p3
主要言語
Java
スター
163
フォーク
80
PR マージ指標
30日以内にマージされた PR はありません

説明

Dashboard (and Linkage Checker's ClassPathBuilder) to take an option to resolve dependency graphs with Gradle's way.

While reading errors in https://github.com/GoogleCloudPlatform/cloud-opensource-java/pull/1982#issuecomment-812277520, I noticed that the dependency conflicts (due to picking up old library versions) do not occur to Gradle users.

# Where is this affected?

The `LtsCompatibilityTestRunner` resolves the dependencies of the BOM:

```
ImmutableList bomManagedDependencies = bom.getManagedDependencies();
ClassPathBuilder classPathBuilder = new ClassPathBuilder();
ClassPathResult resolvedDependencies = classPathBuilder.resolve(bomManagedDependencies, false);
```

This resolves the dependencies in Maven's closest-win strategy. This strategy is prone to getting old dependencies which cause dependency conflicts. For Gradle users, the resolution is different; it uses highest-win strategy. Therefore, the current result shown in the pull request contain false positives and false negatives.

# GradleDependencyMediation?

We already have `MavenDependencyMediation`. I think the implementation would be creating GradleDependencyMediation.

コントリビューションガイド

コントリビューションガイドを開く

評価

この issue はまだ評価されていません。

新しい issue をメールで受け取る

初心者向けの GitHub issue を短くまとめたダイジェスト。