FormidableLabs / FormidableLabs/babel-plugin-transform-define

wrong babel cache using filepath as entry point

Ouverte
#47 3 commentaires 0 réactions 0 personnes assignées Voir sur GitHub
unverified
Langage dominant
JavaScript
Étoiles
242
Forks
29
Métriques de merge des PR
Aucune PR mergée en 30 j

Description

Hey folks, thanks for creating this library, I found it very useful.

I'm opening this issue because I found an edge case related to how babel-loader cache works.

babel-loader uses a prop called `cachedIdentifier`. This property determinate if it is necessary or not re-run babel-loader process.

https://github.com/babel/babel-loader/blob/b29516266912fbc50120155fee00efb1b0a19f59/src/index.js#L61

The point here is that it reads the content of the `.babelrc`. All is okay.

The edge case is related with this:

```
{
"plugins": [
["transform-define", "./path/to/config/file.js"]
]
}
```

If you use `babel-plugin-transform-define` specifying a file path, and then you modify the content of the file, in the next babel-loader it will be determinate that a new run is not necessary, so it will be served the last result from the cache that it's different from your expected result!

Literally, I was thinking I was crazy until discovering this.

The fix could be easiest as determinate the new way to calculate `cachedIdentifier`. The problem is, because in my case I'm under Next.js, that's is not something easy to do because Next.js internal doesn't contemplate this modification.

Ideally, we should do that transparently adding a bit of code inside `babel-plugin-transform-define` to detect the edge case, but not sure if we can do that, need to investigate around babel-loader API inside a plugin.

My current workaround is remove the cache before init the process:

```
rm -rf node_modules/.cache/babel-loader && npm run dev
```
but obviously, this is a very bad solution and slow.

any idea? 🙂

Guide de contribution

Ouvrir le guide de contribution

Piste de recherche

Commencez par la logique cachedIdentifier associée dans src/index.js de babel-loader et examinez comment babel-plugin-transform-define reçoit ou résout le chemin de son fichier de configuration. Reproduisez le cas de cache obsolète en modifiant le fichier référencé, puis définissez l’achèvement comme l’invalidation du cache lorsque le contenu de ce fichier change, sans supprimer manuellement node_modules/.cache/babel-loader.

Rédigé par le modèle d'indexation à partir du texte de l'issue.

Évaluation

Stack technique
javascript
Domaine
build-system
Type d'issue
Bug
Difficulté
4/5
Temps estimé
3-5 jours
Activité
À l'abandon
Clarté
À clarifier
Accessibilité débutants
30/100

Recevez les nouvelles issues par e-mail

Un résumé court des issues GitHub adaptées aux débutants.