FormidableLabs / FormidableLabs/babel-plugin-transform-define

wrong babel cache using filepath as entry point

Abierto
#47 3 comentarios 0 reacciones 0 asignados Ver en GitHub
unverified
Lenguaje dominante
JavaScript
Estrellas
242
Forks
29
Métricas de merge de PR
Sin PR fusionados en 30 d

Descripción

Hey folks, thanks for creating this library, I found it very useful.

I'm opening this issue because I found an edge case related to how babel-loader cache works.

babel-loader uses a prop called `cachedIdentifier`. This property determinate if it is necessary or not re-run babel-loader process.

https://github.com/babel/babel-loader/blob/b29516266912fbc50120155fee00efb1b0a19f59/src/index.js#L61

The point here is that it reads the content of the `.babelrc`. All is okay.

The edge case is related with this:

```
{
"plugins": [
["transform-define", "./path/to/config/file.js"]
]
}
```

If you use `babel-plugin-transform-define` specifying a file path, and then you modify the content of the file, in the next babel-loader it will be determinate that a new run is not necessary, so it will be served the last result from the cache that it's different from your expected result!

Literally, I was thinking I was crazy until discovering this.

The fix could be easiest as determinate the new way to calculate `cachedIdentifier`. The problem is, because in my case I'm under Next.js, that's is not something easy to do because Next.js internal doesn't contemplate this modification.

Ideally, we should do that transparently adding a bit of code inside `babel-plugin-transform-define` to detect the edge case, but not sure if we can do that, need to investigate around babel-loader API inside a plugin.

My current workaround is remove the cache before init the process:

```
rm -rf node_modules/.cache/babel-loader && npm run dev
```
but obviously, this is a very bad solution and slow.

any idea? 🙂

Guía de contribución

Abrir la guía de contribución

Línea de trabajo

Comienza con la lógica vinculada de cachedIdentifier en src/index.js de babel-loader y revisa cómo babel-plugin-transform-define recibe o resuelve la ruta de su archivo de configuración. Reproduce el caso de caché obsoleto cambiando el archivo referenciado y define la finalización como la invalidación de la caché cuando cambie el contenido de ese archivo sin eliminar manualmente node_modules/.cache/babel-loader.

Escrito por el modelo de indexación a partir del texto del issue.

Evaluación

Stack tecnológico
javascript
Área
build-system
Tipo de issue
Error
Dificultad
4/5
Tiempo estimado
3-5 días
Estado de actividad
Estancado
Claridad
Necesita aclaración
Aptitud para principiantes
30/100

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.