Flagsmith / Flagsmith/flagsmith-sql-flag-engine

PERCENTAGE_SPLIT: implement engine's 1-in-9999 recursion edge case in SQL

未关闭
#4 0 条评论 0 个 reaction 已指派 0 人 在 GitHub 查看
主要语言
Python
星标
1
派生
0
PR 合并指标
30 天内没有已合并 PR

描述

The pure-SQL `PERCENTAGE_SPLIT` hash diverges from the engine on the ~1/9999 inputs where the bare hash mod 9999 == 9998 (the engine recurses with doubled input; this implementation skips).

Real-world impact at typical thresholds: ~0.005% false-negative rate on the count of identities matching a percentage-split segment. At 870M with threshold 50, that's ~22k false-negatives across the env — a rounding error on a count-badge UI but a measurable bias if anyone uses the count for billing or contract decisions.

## What to ship

Implement the recursion as a `CASE WHEN bare_hash_mod = 9998 THEN ELSE END` wrapper in the inline SQL. The recursive hash uses doubled input: `seg_key || ',' || value || ',' || seg_key || ',' || value`. Cap at 2-3 iterations (engine recurses arbitrarily but in practice the second iteration almost always lands at non-9998).

## Why deferred

Sub-0.005% bias on a UI count is below the threshold that customers care about. Defer until a customer reports a discrepancy or until the engine's bucketing semantics change.

贡献指南

这个仓库没有索引到贡献指南

调研方向

Locate the inline SQL implementation of PERCENTAGE_SPLIT and compare its bare-hash handling with the engine semantics described in the issue. Implement and verify the doubled-input recursion for bare_hash_mod = 9998, capped at 2-3 iterations, and confirm that ordinary inputs retain their existing results.

由索引模型根据 Issue 内容生成。

评估

技术栈
python, sql
领域
databases
Issue 类型
缺陷
难度
3/5
预计耗时
1-2 天
活跃度
冷清
描述清晰度
基本清楚
新手友好度
48/100

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。