Flagsmith / Flagsmith/flagsmith-python-client

`test_environment_does_not_update_on_past_event` is flaky

オープン
#187 コメント 0 件 リアクション 0 件 担当者 0 名 GitHub で見る
主要言語
Python
スター
24
フォーク
12
平均マージ
15時間 43分
マージ済み PR(30日)
4

説明

The following test is failing sometimes for Python 3.10:

```
============================= test session starts ==============================
platform linux -- Python 3.10.19, pytest-7.4.4, pluggy-1.5.0
rootdir: /home/runner/work/flagsmith-python-client/flagsmith-python-client
plugins: mock-3.14.1, cov-4.1.0, pyfakefs-5.9.2
collected 73 items

tests/test_analytics.py ..... [ 6%]
tests/test_flagsmith.py ........................................... [ 65%]
tests/test_models.py ............ [ 82%]
tests/test_offline_handlers.py .. [ 84%]
tests/test_polling_manager.py .... [ 90%]
tests/test_streaming_manager.py ..F. [ 95%]
tests/test_webhooks.py ... [100%]

=================================== FAILURES ===================================
________________ test_environment_does_not_update_on_past_event ________________

self =

def assert_not_called(self):
"""assert that the mock was never called.
"""
if self.call_count != 0:
msg = ("Expected '%s' to not have been called. Called %s times.%s"
% (self._mock_name or 'mock',
self.call_count,
self._calls_repr()))
> raise AssertionError(msg)
E AssertionError: Expected 'update_environment' to not have been called. Called 2 times.
E Calls: [call(), call()].

/opt/hostedtoolcache/Python/3.10.19/x64/lib/python3.10/unittest/mock.py:890: AssertionError

During handling of the above exception, another exception occurred:

server_api_key = 'ser.ZnjtUuLXOhrkpIQbVTJR'
mocker =

def test_environment_does_not_update_on_past_event(
server_api_key: str, mocker: MockerFixture
) -> None:
stream_updated_at = datetime(2020, 1, 1, 1, 1, 1, tzinfo=timezone.utc)
environment_updated_at = datetime(2020, 1, 1, 1, 1, 2, tzinfo=timezone.utc)

mocker.patch("flagsmith.Flagsmith.update_environment")

flagsmith = Flagsmith(environment_key=server_api_key)
flagsmith._evaluation_context = MagicMock()
flagsmith._environment_updated_at = environment_updated_at

flagsmith.handle_stream_event(event=StreamEvent(updated_at=stream_updated_at))
assert isinstance(flagsmith.update_environment, Mock)
> flagsmith.update_environment.assert_not_called()
E AssertionError: Expected 'update_environment' to not have been called. Called 2 times.
E Calls: [call(), call()].

tests/test_streaming_manager.py:68: AssertionError
=========================== short test summary info ============================
FAILED tests/test_streaming_manager.py::test_environment_does_not_update_on_past_event - AssertionError: Expected 'update_environment' to not have been called. Called 2 times.
Calls: [call(), call()].
========================= 1 failed, 72 passed in 0.80s =========================
```

コントリビューションガイド

コントリビューションガイドを開く

評価

この issue はまだ評価されていません。

新しい issue をメールで受け取る

初心者向けの GitHub issue を短くまとめたダイジェスト。