FirebaseExtended / FirebaseExtended/reactfire

Disabling queries via ReactFireOptions

オープン
#346 コメント 1 件 リアクション 8 件 担当者 0 名 GitHub で見る
v5
主要言語
TypeScript
スター
3.6k
フォーク
403
平均マージ
14時間 53分
マージ済み PR(30日)
5

説明

I've read the discussion in #178 and am yet another person that has run into the wall of "can't use the hooks with a not-yet-defined id". I understand and agree with your desire to keep undefined/null ids as errors. But we still run into situations where the use of react-fire hooks constrains our design decisions and requires us to make several small components that issue the same query when one query would do and would allow us to present the UI in a single component as we wish.

I suggest adopting something similar to [how react-query handles this](https://react-query.tanstack.com/guides/disabling-queries). Passing in an `enabled` flag to the `ReactFireOptions` object which would prevent the query from executing if `enabled === false` (and instead returning `initialData`, if defined). This would allow the errors to persist when inadvertently passing in undefined/null, but also allow consumers to make their own design decisions when constructing dependent queries.

Alternatively, add an `exists` property to the `ObservableStatus` so that we can determine, without an additional query, whether the ref already exists. Currently when I have a dependent query I pass in an ID that I know not to exist, e.g. "-1", but I get back a document that has a firestore-generated ID and nothing else. Without the ability to disable the query or determine if the ref exists I rely on the object being otherwise empty to determine if I should return an `undefined` or not.

コントリビューションガイド

コントリビューションガイドを開く

調査の方向性

The issue names ReactFireOptions and ObservableStatus as the relevant entry points; begin by tracing how the ReactFire hooks execute queries and expose status. Compare the proposed enabled behavior with the alternative exists status, including initialData handling. Done means dependent queries can avoid unintended execution or reliably determine reference existence without treating placeholder data as a result.

索引モデルが issue の本文から書いたものです。

評価

技術スタック
firebase, react, typescript
領域
frontend
issue の種類
機能追加
難易度
4/5
見積もり時間
3〜5日
活発さ
停滞
明瞭さ
おおむね明確
初心者へのやさしさ
35/100

新しい issue をメールで受け取る

初心者向けの GitHub issue を短くまとめたダイジェスト。