FasterXML / FasterXML/java-classmate

Correct approach to compare `ResolvedType` with a raw `Class<?>`?

Open
#72 3 comments 0 reactions 0 assignees View on GitHub
Dominant language
Java
Stars
266
Forks
47
Avg merge
1h 42m
Merged PRs (30d)
1

Description

What's the appropriate way to see if a `ResolvedType` represents a simple class that I know about?

Let's say I pass a `new GenericType{}` to a method, and I just want to see if the generic parameter is `String`. I think (I haven't tried it yet) I would do this (code not optimized, for illustration):

```java
void foo(GenericType genericType) {
TypeResolver typeResolver = new TypeResolver();
ResolvedType resolvedType = typeResolver.resolve(genericType);
```

How would I then see if `resolvedType` indicates a simple `String`? I'm guessing I could do this:

```java
if(resolvedType.getTypeParameters.isEmpty() && resolvedType.getErasedType().equals(String.class)) {

```

But that seems sort of awkward. Is there a better way?

(Note that the `resolvedType.getTypeParameters.isEmpty()` check is arguably not necessary here, as `String` has no generic parameters, but I'm looking for a general approach.)

Or should I be going in the other direction, resolving `String.class` and then comparing the resolved types?

```java
if(resolvedType.equals(typeResolver.resolve(String.class))) {

```

I don't know how much overhead the extra resolution of `String.class` adds, though.

This may be related to #31.

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.