FPFSoftware / FPFSoftware/FPFSim

Merge `primaries` and `trajectories` into a single "particles" tree

Đang mở
#18 0 bình luận 0 reaction 1 người được giao Được @mvicenzi nhận Xem trên GitHub
enhancement
Ngôn ngữ chính
C++
Star
2
Fork
1
Chỉ số merge pull request
Không có pull request nào được merge trong 30 ngày

Mô tả

The `primaries` and `trajectories` TTrees defined in #16 could be merged into a single "particles" tree which will contain the entire particle hierarchy (not just primaries). Based on the discussion in #2 , this could serve as the ACTS-required particle tree as well.

Storing the full particle hierarchy tree is certainly interesting, as one would otherwise be somewhat blind if relying only on primaries and the hits that end up in a sensitive volume. Moreover, this would also tip things in favor of moving all pseudo-reco/reco downstream/outside of FPFSim as literally all truth info will be made available.

The only concern is the size of such a tree... which is certainly a lot if full trajectory points are saved.
And even if the trajectories points are not written to file, asking G4 to store all the tracks is quite memory intensive.

A solution could be:
- implement our own G4Trajectory class ;
- the class will have a flag to store trajectory points or not;
- then G4 would store only light-weight custom tracks, which is probably acceptable in terms of memory usage, unless we explicitly ask for full trajectory points (like for input to `FPFDisplay`);
- tracks can be recovered from storage in the AnalysisManager (like we do now) and used to fill the tree;

Comments/suggestions are welcomed!

Hướng dẫn đóng góp

Chưa lập chỉ mục được hướng dẫn đóng góp cho kho mã nguồn này

Đánh giá

Issue này chưa được đánh giá.

Nhận issue mới trong hộp thư của bạn

Bản tóm tắt ngắn những issue GitHub phù hợp với người mới.