FAForever / FAForever/server

Remove avatar related commands from protocol and tables from model

オープン
#611 コメント 10 件 リアクション 0 件 担当者 0 名 GitHub で見る
主要言語
Python
スター
72
フォーク
84
平均マージ
5時間 11分
マージ済み PR(30日)
1

説明

Avatars are managed by the API.
There is no more need to have this in the protocol except for python client.

Why now? We recently removed the `url` column from the database and replaced it with a `filename` column. The main reason behind this change is that we want to decouple the filename from the url (we want to be able to move file around if we need to). Then the prefix to the content server should be configuration only (which it is now in the API).

For now the `url` column is kept for backward compatibility by adding the prefix hardcoded, but we want to remove this. Therefore we either put the url prefix as configuration in the server or we just remove the protocol and the tables from the server which reduces complextiy which is unneeded.

This will break the avatars in the python client, but due to url encoding issues we solved now in the api they are partially broken already.
Alternative for the python client: Use the avatar endpoints available since Q1 2018.

コントリビューションガイド

コントリビューションガイドを開く

評価

この issue はまだ評価されていません。

新しい issue をメールで受け取る

初心者向けの GitHub issue を短くまとめたダイジェスト。