FAForever / FAForever/server

Redesign party commands

Ouverte
#600 1 commentaire 0 réactions 0 personnes assignées Voir sur GitHub
Langage dominant
Python
Étoiles
72
Forks
84
Merge moyen
5 h 11 min
PR mergées (30 j)
1

Description

It may be better to send party commands using a single command with many subcommands than our current implementation of having a separate command for every action.

We could go with a "polymorphic" approach:
```
{
"command": "party",
"action": "invite",
"recipient_id":
}
```

Or more of a "compositional" approach:
```
{
"command": "party",
"action": "invite",
"data": {
"recipient_id":
}
}
```

The compositional approach has a little more boilerplate built into the message, but it feels cleaner to me.

Guide de contribution

Ouvrir le guide de contribution

Évaluation

Cette issue n'a pas encore été évaluée.

Recevez les nouvelles issues par e-mail

Un résumé court des issues GitHub adaptées aux débutants.