FAForever / FAForever/server

Redesign party commands

Open
#600 1 comment 0 reactions 0 assignees View on GitHub
Dominant language
Python
Stars
72
Forks
84
Avg merge
5h 11m
Merged PRs (30d)
1

Description

It may be better to send party commands using a single command with many subcommands than our current implementation of having a separate command for every action.

We could go with a "polymorphic" approach:
```
{
"command": "party",
"action": "invite",
"recipient_id":
}
```

Or more of a "compositional" approach:
```
{
"command": "party",
"action": "invite",
"data": {
"recipient_id":
}
}
```

The compositional approach has a little more boilerplate built into the message, but it feels cleaner to me.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.