FAForever / FAForever/faftools
Maps may break
- Lingua principale
- Python
- Stelle
- 1
- Fork
- 8
- Metriche di merge delle PR
- Nessuna PR unita negli ultimi 30g
Descrizione
Generate Map Upload may break the map
* it get the name from `scenario.lua` `map` key and replace it with a new one case sensitive. (https://github.com/FAForever/faftools/blob/982073d556b43963e6fc9f6356aad484416d8b84/faf/tools/fa/maps.py#L366)
* Replace maybe miss some expressions (https://github.com/FAForever/faftools/blob/982073d556b43963e6fc9f6356aad484416d8b84/faf/tools/fa/maps.py#L276)
https://faforever.slack.com/archives/general/p1485308092008963
Solution:
* still rename map folder to `.v<0-4version>`
* replace the `maps\` with the new `maps\.v<0-4version>`
* don't rename other lua files, because it errorprone to replace references
Guida per i contributori
Nessuna guida per i contributori indicizzata per questo repository
Valutazione
Questa issue non è ancora stata valutata.