FAForever / FAForever/faftools

Maps may break

Open
#26 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
Python
Stars
1
Forks
8
PR merge metrics
No merged PRs in 30d

Description

Generate Map Upload may break the map

* it get the name from `scenario.lua` `map` key and replace it with a new one case sensitive. (https://github.com/FAForever/faftools/blob/982073d556b43963e6fc9f6356aad484416d8b84/faf/tools/fa/maps.py#L366)
* Replace maybe miss some expressions (https://github.com/FAForever/faftools/blob/982073d556b43963e6fc9f6356aad484416d8b84/faf/tools/fa/maps.py#L276)

https://faforever.slack.com/archives/general/p1485308092008963

Solution:

* still rename map folder to `.v<0-4version>`
* replace the `maps\` with the new `maps\.v<0-4version>`
* don't rename other lua files, because it errorprone to replace references

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.