Election-Tech-Initiative / Election-Tech-Initiative/electionguard-cpp

C# use IDisposable to avoid unnecessary copies

Aperta
#164 3 commenti 0 reazioni 0 assegnatari Vedi su GitHub
enhancement hacktoberfest help wanted
Lingua principale
C++
Stelle
26
Fork
25
Metriche di merge delle PR
Nessuna PR unita negli ultimi 30g

Descrizione

## Feature Request

**Description**
In a few places, there are unnecessary copy operations when moving between managed and unmanaged blocks of memory. For instance:
- `Group.cs#ElementModP#NewNative`
- `Ballot.cs#CompactCiphertextBallot#ctor`

This request is to refactor the managed code to expose the unmanaged objects directly where necessary by pinning the memory and bypassing the garbage collector. IDisposable should be used on the managed side to call the unmanaged "_free" functions when necessary. Careful consideration must be given to ownership as not every contiguous block of memory returned to managed code is actually owned by the caller.

The implemented pattern should be consistently applied throughout the C# binding layer.

Guida per i contributori

Apri la guida per i contributori

Valutazione

Questa issue non è ancora stata valutata.

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.