Election-Tech-Initiative / Election-Tech-Initiative/electionguard-cpp

C# use IDisposable to avoid unnecessary copies

Ouverte
#164 3 commentaires 0 réactions 0 personnes assignées Voir sur GitHub
enhancement hacktoberfest help wanted
Langage dominant
C++
Étoiles
26
Forks
25
Métriques de merge des PR
Aucune PR mergée en 30 j

Description

## Feature Request

**Description**
In a few places, there are unnecessary copy operations when moving between managed and unmanaged blocks of memory. For instance:
- `Group.cs#ElementModP#NewNative`
- `Ballot.cs#CompactCiphertextBallot#ctor`

This request is to refactor the managed code to expose the unmanaged objects directly where necessary by pinning the memory and bypassing the garbage collector. IDisposable should be used on the managed side to call the unmanaged "_free" functions when necessary. Careful consideration must be given to ownership as not every contiguous block of memory returned to managed code is actually owned by the caller.

The implemented pattern should be consistently applied throughout the C# binding layer.

Guide de contribution

Ouvrir le guide de contribution

Évaluation

Cette issue n'a pas encore été évaluée.

Recevez les nouvelles issues par e-mail

Un résumé court des issues GitHub adaptées aux débutants.