DiamondLightSource / DiamondLightSource/python-dlstbx
Return XRC locations in physical coordinates rather than boxes
- 主要语言
- Python
- 星标
- 2
- 派生
- 2
- 平均合并
- 1 天 11 小时
- 30 天内合并 PR
- 2
描述
From a hyperion point of view it will be a lot cleaner if zocalo returned results in mm/um rather than boxes so that we do not have to do the conversion in the DAQ side. The setpoints of the gridscan should already be written to the nexus file and are already read by the 3D XRC anyway (https://github.com/DiamondLightSource/python-dlstbx/blob/75915e38e138fe0c90d4ab1dd1a9ec2b76f6afb3/src/dlstbx/cli/gridscan3d.py#L95). Additionally, the readback values of the gridscan will soon be in there too https://github.com/DiamondLightSource/mx-bluesky/issues/597.
## Notes
* This may require some correction on the hyperion side if we're not correctly writing the positions, see https://github.com/DiamondLightSource/mx-bluesky/issues/414
* We will probably want to keep the box co-ordinates in the result too as they may be useful
## Acceptance
* Zocalo additionally returns XRC results in position coordinates
贡献指南
这个仓库没有索引到贡献指南
调研方向
Start by tracing how Zocalo returns XRC results and read the linked gridscan3d.py entry point around line 95, where grid-scan setpoints are read from the NeXus file. Check the related mx-bluesky issues for position-writing and readback context. Done means XRC results additionally contain physical position coordinates while retaining box coordinates.
由索引模型根据 Issue 内容生成。
评估
- 技术栈
- python
- 领域
- backend-api-design
- Issue 类型
- 功能
- 难度
- 4/5
- 预计耗时
- 3-5 天
- 活跃度
- 冷清
- 描述清晰度
- 基本清楚
- 新手友好度
- 42/100