DiamondLightSource / DiamondLightSource/python-dlstbx
Return XRC locations in physical coordinates rather than boxes
- Lenguaje dominante
- Python
- Estrellas
- 2
- Forks
- 2
- Merge medio
- 1 d 11 h
- PR fusionados (30 d)
- 2
Descripción
From a hyperion point of view it will be a lot cleaner if zocalo returned results in mm/um rather than boxes so that we do not have to do the conversion in the DAQ side. The setpoints of the gridscan should already be written to the nexus file and are already read by the 3D XRC anyway (https://github.com/DiamondLightSource/python-dlstbx/blob/75915e38e138fe0c90d4ab1dd1a9ec2b76f6afb3/src/dlstbx/cli/gridscan3d.py#L95). Additionally, the readback values of the gridscan will soon be in there too https://github.com/DiamondLightSource/mx-bluesky/issues/597.
## Notes
* This may require some correction on the hyperion side if we're not correctly writing the positions, see https://github.com/DiamondLightSource/mx-bluesky/issues/414
* We will probably want to keep the box co-ordinates in the result too as they may be useful
## Acceptance
* Zocalo additionally returns XRC results in position coordinates
Guía de contribución
No hay ninguna guía de contribución indexada para este repositorio
Línea de trabajo
Start by tracing how Zocalo returns XRC results and read the linked gridscan3d.py entry point around line 95, where grid-scan setpoints are read from the NeXus file. Check the related mx-bluesky issues for position-writing and readback context. Done means XRC results additionally contain physical position coordinates while retaining box coordinates.
Escrito por el modelo de indexación a partir del texto del issue.
Evaluación
- Stack tecnológico
- python
- Área
- backend-api-design
- Tipo de issue
- Nueva funcionalidad
- Dificultad
- 4/5
- Tiempo estimado
- 3-5 días
- Estado de actividad
- Tranquilo
- Claridad
- Bastante claro
- Aptitud para principiantes
- 42/100