DeployBoard / DeployBoard/deployboard-python

Implement Okta allowed_groups and allowed_domains

Đang mở
#143 0 bình luận 0 reaction 0 người được giao Xem trên GitHub
enhancement
Ngôn ngữ chính
Python
Star
10
Fork
1
Chỉ số merge pull request
Không có pull request nào được merge trong 30 ngày

Mô tả

**Is your feature request related to a problem? Please describe.**
We can support additional security around Okta auth by implementing `allowed_groups` and `allowed_domains`.
This would restrict who can even log into the application, although personally, I don't think there is any reason to deny anyone in your organization access to DeployBoard, but that's not my call to make about your org, so we'd like to support the option at least.

**Describe the solution you'd like**
After the Okta Oauth2 workflow, we retrieve the user's info and check if they are in any of the `allowed_groups` in the config.

We additionally would check the Okta domain the request is coming from to verify the domain matches the `allowed_domains` list. I kinda think this one is a bit redundant, since we require you to put the Okta client and secret in the config, so that should always match the domain associated with that client right? We're planning to support it anyway.

**Describe alternatives you've considered**
None

**Additional context**
None

Hướng dẫn đóng góp

Chưa lập chỉ mục được hướng dẫn đóng góp cho kho mã nguồn này

Đánh giá

Issue này chưa được đánh giá.

Nhận issue mới trong hộp thư của bạn

Bản tóm tắt ngắn những issue GitHub phù hợp với người mới.