DLR-RM / DLR-RM/RAFCON

Wrong interpretation of MAX_VISIBLE_LIBRARY_HIERARCHY

Open
#22 2 comments 0 reactions 0 assignees View on GitHub
bug low priority
Dominant language
Python
Stars
212
Forks
39
PR merge metrics
No merged PRs in 30d

Description

For the statemachine: unit_test_state_machines/deep_libraries/library_middle2

It has 33 States (library state instances count as two states, one for the library wrapper and one for the state_copy).

If MAX_VISIBLE_LIBRARY_HIERARCHY is set to 3 than all 33 Models for the states are loaded, which is correct. 3 levels of hierarchies are shown if a show-flag is enabled, which is also correct.

If MAX_VISIBLE_LIBRARY_HIERARCHY is set to 2 also all 33 Models for the states are loaded as well, which is wrong! Only 2 levels of hierarchies are shown if a show-flag is enabled, which is actually correct. Thus, a lot of models are created, but not shown using the show flag.

For bigger state machines, this drastically increases the loading time by a factor of FOUR!
E.g. for the unit_test_state_machines/deep_libraries/sm with deepest libraries!

For our LRU state machines, this is even worse!

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.