ComputerScienceHouse / ComputerScienceHouse/schedulemaker

Generated ical series not accounting for public and univiersity holidays

未关闭
#344 3 条评论 0 个 reaction 已指派 0 人 在 GitHub 查看
bug
主要语言
PHP
星标
66
派生
39
平均合并
3 小时 44 分钟
30 天内合并 PR
1

描述

Thanks for the work done closing #63 in #343, I just tried out the new changes and it looks like it largely works!

I did notice that, because the first week of class starts with MLK day, it is causing all of my MWF classes to not generate until the next week
![Screenshot_20240111_113526](https://github.com/ComputerScienceHouse/schedulemaker/assets/17362949/b085592b-3ce3-4964-9820-280faecf18ea)

![Screenshot_20240111_113713](https://github.com/ComputerScienceHouse/schedulemaker/assets/17362949/5f44bc54-9883-4292-b359-18a3d2eddfac)

Additionally, it seems to be generating events through RIT's Spring break
![Screenshot_20240111_113555](https://github.com/ComputerScienceHouse/schedulemaker/assets/17362949/d2add325-6651-4c9f-8682-496b43be8ba8)

since RIT's institute calendar also includes the public holidays that we have no class, this may be relatively easy to implement:

1. scrape, or get ITS to add an iCal version of the data from https://www.rit.edu/calendar
2. add some code to filter days off out from other institute events things (such as the last day of the add/drop period) and convert to DateTime format
3. follow the linked specs to include them as exception dates in each VEVENT declaration https://icalendar.org/iCalendar-RFC-5545/3-8-5-1-exception-date-times.html (thanks @natep-tech for the link)

Unless RIT can maintain the list of days off (which IMO it should) this may add some extra maintenance burden to CSH. However some of the open source groups at RIT may also be able to help take this on as well in the meantime.

贡献指南

这个仓库没有索引到贡献指南

评估

这个 Issue 还没有评估数据。

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。