ComputerScienceHouse / ComputerScienceHouse/schedulemaker

Generated ical series not accounting for public and univiersity holidays

Ouverte
#344 3 commentaires 0 réactions 0 personnes assignées Voir sur GitHub
bug
Langage dominant
PHP
Étoiles
66
Forks
39
Merge moyen
3 h 44 min
PR mergées (30 j)
1

Description

Thanks for the work done closing #63 in #343, I just tried out the new changes and it looks like it largely works!

I did notice that, because the first week of class starts with MLK day, it is causing all of my MWF classes to not generate until the next week
![Screenshot_20240111_113526](https://github.com/ComputerScienceHouse/schedulemaker/assets/17362949/b085592b-3ce3-4964-9820-280faecf18ea)

![Screenshot_20240111_113713](https://github.com/ComputerScienceHouse/schedulemaker/assets/17362949/5f44bc54-9883-4292-b359-18a3d2eddfac)

Additionally, it seems to be generating events through RIT's Spring break
![Screenshot_20240111_113555](https://github.com/ComputerScienceHouse/schedulemaker/assets/17362949/d2add325-6651-4c9f-8682-496b43be8ba8)

since RIT's institute calendar also includes the public holidays that we have no class, this may be relatively easy to implement:

1. scrape, or get ITS to add an iCal version of the data from https://www.rit.edu/calendar
2. add some code to filter days off out from other institute events things (such as the last day of the add/drop period) and convert to DateTime format
3. follow the linked specs to include them as exception dates in each VEVENT declaration https://icalendar.org/iCalendar-RFC-5545/3-8-5-1-exception-date-times.html (thanks @natep-tech for the link)

Unless RIT can maintain the list of days off (which IMO it should) this may add some extra maintenance burden to CSH. However some of the open source groups at RIT may also be able to help take this on as well in the meantime.

Guide de contribution

Aucun guide de contribution indexé pour ce dépôt

Évaluation

Cette issue n'a pas encore été évaluée.

Recevez les nouvelles issues par e-mail

Un résumé court des issues GitHub adaptées aux débutants.