ComputerScienceHouse / ComputerScienceHouse/packet

Stop assuming all upperclassmen are on every packet

未关闭
#294 0 条评论 0 个 reaction 已指派 0 人 在 GitHub 查看
good first issue
主要语言
Python
星标
25
派生
33
PR 合并指标
30 天内没有已合并 PR

描述

This line makes the assumption that every single upperclassman is a required signature on every packet. This may not be the case, due to e.g. changes in membership state that don't influence earlier packets. This results in a confusing list of signature counts when an upperclassman is required on only some of the packets, since they are listed as `$num_signed / $num_total` in the active section. This aught to be `$num_signed / $num_can_sign_as_upper`
https://github.com/ComputerScienceHouse/packet/blob/f61cd2b5b616e3b7f35fad95b515313ea2d50bcb/packet/templates/upperclassmen_totals.html#L39

This will probably require injecting more data into the upperclassmen dict here so that it's accessible in the template.
https://github.com/ComputerScienceHouse/packet/blob/f61cd2b5b616e3b7f35fad95b515313ea2d50bcb/packet/routes/upperclassmen.py#L51-L62

贡献指南

这个仓库没有索引到贡献指南

调研方向

Start with packet/templates/upperclassmen_totals.html at line 39 and packet/routes/upperclassmen.py at lines 51-62. Trace how the upperclassmen data reaches the active section, then ensure the displayed denominator counts only packets each upperclassman can sign. Done means the active counts use num_can_sign_as_upper rather than num_total when membership state excludes earlier packets.

由索引模型根据 Issue 内容生成。

评估

技术栈
flask, python
领域
backend
Issue 类型
缺陷
难度
3/5
预计耗时
1-2 天
活跃度
停滞
描述清晰度
描述清楚
新手友好度
52/100

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。