ComputerScienceHouse / ComputerScienceHouse/packet
Stop assuming all upperclassmen are on every packet
- Lingua principale
- Python
- Stelle
- 25
- Fork
- 33
- Metriche di merge delle PR
- Nessuna PR unita negli ultimi 30g
Descrizione
This line makes the assumption that every single upperclassman is a required signature on every packet. This may not be the case, due to e.g. changes in membership state that don't influence earlier packets. This results in a confusing list of signature counts when an upperclassman is required on only some of the packets, since they are listed as `$num_signed / $num_total` in the active section. This aught to be `$num_signed / $num_can_sign_as_upper`
https://github.com/ComputerScienceHouse/packet/blob/f61cd2b5b616e3b7f35fad95b515313ea2d50bcb/packet/templates/upperclassmen_totals.html#L39
This will probably require injecting more data into the upperclassmen dict here so that it's accessible in the template.
https://github.com/ComputerScienceHouse/packet/blob/f61cd2b5b616e3b7f35fad95b515313ea2d50bcb/packet/routes/upperclassmen.py#L51-L62
Guida per i contributori
Nessuna guida per i contributori indicizzata per questo repository
Valutazione
Questa issue non è ancora stata valutata.