ComputerScienceHouse / ComputerScienceHouse/gallery
Images arent always displayed in the correct orientation when viewing an image
- Dominant language
- Python
- Stars
- 22
- Forks
- 30
- Avg merge
- 2h 26m
- Merged PRs (30d)
- 1
Description
When viewing images taken vertically (i.e. https://gallery.csh.rit.edu/view/file/36582), [some browsers](https://caniuse.com/#search=image-orientation) (i.e. new versions of firefox) correctly rotate the image based on its EXIF metadata, however, most browsers (i.e. chromium) still display it incorrectly.
in order to fix this for other browsers, there needs to be a fallback for when the `image-orientation` CSS property is not supported.
So far i've come up with:
1. Since #45 seems to be rotating thumbnails server-side, maybe we could also rotate the images server-side before displaying them, however, it seems like the `/api/files/get` endpoint is just [returning a link to s3](https://github.com/ComputerScienceHouse/gallery/blob/773b30fab2bfac69e6ac7573dc4954d0192fbcf5/gallery/__init__.py#L751), so this might be a pretty complicated way to do it.
2. alternatively, maybe we could implement the rotation using CSS classes and have the `view_file.html` template look at the metadata and decide which to use
Contributor guide
No contributing guide indexed for this repository
Assessment
This issue has not been assessed yet.