CommunityToolkit / CommunityToolkit/Windows
Clean up suppression of CA1063 and implement IDisposable correctly
- Lingua principale
- C#
- Stelle
- 1.1k
- Fork
- 166
- Metriche di merge delle PR
- Nessuna PR unita negli ultimi 30g
Descrizione
From https://github.com/CommunityToolkit/Tooling-Windows-Submodule/issues/63
One or more components in this repository are suppressing CA1063. To avoid memory leaks in certain edge cases, we should be implementing the full `IDisposable` pattern and not suppressing this warning.
[Affected components](https://github.com/search?q=repo%3ACommunityToolkit%2FWindows+disable+CA1063&type=code):
- [CameraHelper](https://github.com/CommunityToolkit/Windows/blob/744e6aba53329b3f04980237ca4d19eae3fbd5c9/components/Helpers/src/CameraHelper/CameraHelper.cs#L16)
- [AdvancedCollectionView](https://github.com/CommunityToolkit/Windows/blob/744e6aba53329b3f04980237ca4d19eae3fbd5c9/components/AdvancedCollectionView/src/AdvancedCollectionView.Defer.cs#L24)
- [ExpressionNode](https://github.com/CommunityToolkit/Windows/blob/744e6aba53329b3f04980237ca4d19eae3fbd5c9/components/Animations/src/Expressions/ExpressionNodes/ExpressionNode.cs#L18) (from Animations package)
Guida per i contributori
Apri la guida per i contributori
Direzione di ricerca
Inspect CameraHelper.cs, AdvancedCollectionView.Defer.cs, and ExpressionNode.cs at the linked locations, then trace how each component owns disposable resources. Verify the CA1063 suppressions and existing disposal behavior first; done means the affected components implement the full IDisposable pattern without suppressing CA1063.
Scritto dal modello di indicizzazione a partire dal testo della issue.
Valutazione
- Stack tecnologico
- csharp
- Ambito
- tooling
- Tipo di issue
- Refactoring
- Difficoltà
- 4/5
- Tempo stimato
- 3-5 giorni
- Stato di attività
- Ferma
- Chiarezza
- Abbastanza chiara
- Idoneità per principianti
- 35/100