CommunityToolkit / CommunityToolkit/Windows
Clean up suppression of CA1063 and implement IDisposable correctly
- Dominant language
- C#
- Stars
- 1.1k
- Forks
- 166
- PR merge metrics
- No merged PRs in 30d
Description
From https://github.com/CommunityToolkit/Tooling-Windows-Submodule/issues/63
One or more components in this repository are suppressing CA1063. To avoid memory leaks in certain edge cases, we should be implementing the full `IDisposable` pattern and not suppressing this warning.
[Affected components](https://github.com/search?q=repo%3ACommunityToolkit%2FWindows+disable+CA1063&type=code):
- [CameraHelper](https://github.com/CommunityToolkit/Windows/blob/744e6aba53329b3f04980237ca4d19eae3fbd5c9/components/Helpers/src/CameraHelper/CameraHelper.cs#L16)
- [AdvancedCollectionView](https://github.com/CommunityToolkit/Windows/blob/744e6aba53329b3f04980237ca4d19eae3fbd5c9/components/AdvancedCollectionView/src/AdvancedCollectionView.Defer.cs#L24)
- [ExpressionNode](https://github.com/CommunityToolkit/Windows/blob/744e6aba53329b3f04980237ca4d19eae3fbd5c9/components/Animations/src/Expressions/ExpressionNodes/ExpressionNode.cs#L18) (from Animations package)
Contributor guide
Assessment
This issue has not been assessed yet.