CommunityToolkit / CommunityToolkit/Tooling-Windows-Submodule

Hard to use DispatcherQueue/Timer in Labs project

Aperta
#35 2 commenti 0 reazioni 0 assegnatari Vedi su GitHub
bug :bug: dev loop ➰ enhancement templating
Lingua principale
C#
Stelle
55
Fork
19
Merge medio
40m
PR unite (30g)
1

Descrizione

### Describe the bug

These are in two different namespaces `Windows.System` for UWP and Microsoft.UI.Dispatching` for WinAppSDK.

We currently don't include these in our global using in https://github.com/CommunityToolkit/Labs-Windows/blob/main/common/GlobalUsings_WinUI.cs

This means it's not easy to just reference `DispatcherQueue` directly in a Labs experiment, which is probably going to be pretty common.

We should add these namespaces to the global usings and make sure they're easy to use.

I did the same in the Stacked Notifications Behavior here:

https://github.com/CommunityToolkit/Labs-Windows/blob/9045236e77884e6c5c9fccb261e390001c93d4ec/labs/StackedNotificationsBehavior/src/StackedNotificationsBehavior.cs#L5-L13

Which Rive needed as well.

I'm not as sure why I couldn't just include the root namespace for the DispatcherQueue or if that was just an oversight here when initially diagnosing the issue.

### Steps to reproduce

```text
Try and use a DispatcherQueue in an exeperiment
```

### Expected behavior

Shouldn't need to include extra namespaces

### Screenshots

_No response_

### Code Platform

- [X] UWP
- [X] WinAppSDK / WinUI 3
- [ ] Web Assembly (WASM)
- [ ] Android
- [ ] iOS
- [ ] MacOS
- [ ] Linux / GTK

### Windows Build Number

- [ ] Windows 10 1809 (Build 17763)
- [ ] Windows 10 1903 (Build 18362)
- [ ] Windows 10 1909 (Build 18363)
- [ ] Windows 10 2004 (Build 19041)
- [ ] Windows 10 20H2 (Build 19042)
- [ ] Windows 10 21H1 (Build 19043)
- [ ] Windows 11 21H2 (Build 22000)
- [ ] Other (specify)

### Other Windows Build number

_No response_

### App minimum and target SDK version

- [ ] Windows 10, version 1809 (Build 17763)
- [ ] Windows 10, version 1903 (Build 18362)
- [ ] Windows 10, version 1909 (Build 18363)
- [ ] Windows 10, version 2004 (Build 19041)
- [ ] Other (specify)

### Other SDK version

_No response_

### Visual Studio Version

_No response_

### Visual Studio Build Number

_No response_

### Device form factor

_No response_

### Additional context

_No response_

### Help us help you

Yes, but only if others can assist.

Guida per i contributori

Apri la guida per i contributori

Valutazione

Questa issue non è ancora stata valutata.

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.