CommunityToolkit / CommunityToolkit/Tooling-Windows-Submodule

Hard to use DispatcherQueue/Timer in Labs project

Offen
#35 2 Kommentare 0 Reaktionen 0 zugewiesene Personen Auf GitHub ansehen
bug :bug: dev loop ➰ enhancement templating
Vorherrschende Sprache
C#
Sterne
55
Forks
19
Ø Merge
40 Min.
Gemergte PRs (30 T.)
1

Beschreibung

### Describe the bug

These are in two different namespaces `Windows.System` for UWP and Microsoft.UI.Dispatching` for WinAppSDK.

We currently don't include these in our global using in https://github.com/CommunityToolkit/Labs-Windows/blob/main/common/GlobalUsings_WinUI.cs

This means it's not easy to just reference `DispatcherQueue` directly in a Labs experiment, which is probably going to be pretty common.

We should add these namespaces to the global usings and make sure they're easy to use.

I did the same in the Stacked Notifications Behavior here:

https://github.com/CommunityToolkit/Labs-Windows/blob/9045236e77884e6c5c9fccb261e390001c93d4ec/labs/StackedNotificationsBehavior/src/StackedNotificationsBehavior.cs#L5-L13

Which Rive needed as well.

I'm not as sure why I couldn't just include the root namespace for the DispatcherQueue or if that was just an oversight here when initially diagnosing the issue.

### Steps to reproduce

```text
Try and use a DispatcherQueue in an exeperiment
```

### Expected behavior

Shouldn't need to include extra namespaces

### Screenshots

_No response_

### Code Platform

- [X] UWP
- [X] WinAppSDK / WinUI 3
- [ ] Web Assembly (WASM)
- [ ] Android
- [ ] iOS
- [ ] MacOS
- [ ] Linux / GTK

### Windows Build Number

- [ ] Windows 10 1809 (Build 17763)
- [ ] Windows 10 1903 (Build 18362)
- [ ] Windows 10 1909 (Build 18363)
- [ ] Windows 10 2004 (Build 19041)
- [ ] Windows 10 20H2 (Build 19042)
- [ ] Windows 10 21H1 (Build 19043)
- [ ] Windows 11 21H2 (Build 22000)
- [ ] Other (specify)

### Other Windows Build number

_No response_

### App minimum and target SDK version

- [ ] Windows 10, version 1809 (Build 17763)
- [ ] Windows 10, version 1903 (Build 18362)
- [ ] Windows 10, version 1909 (Build 18363)
- [ ] Windows 10, version 2004 (Build 19041)
- [ ] Other (specify)

### Other SDK version

_No response_

### Visual Studio Version

_No response_

### Visual Studio Build Number

_No response_

### Device form factor

_No response_

### Additional context

_No response_

### Help us help you

Yes, but only if others can assist.

Beitragsleitfaden

Beitragsleitfaden öffnen

Rechercherichtung

Inspect common/GlobalUsings_WinUI.cs and compare the namespaces used in the linked Stacked Notifications Behavior file. Verify that a Labs experiment can reference DispatcherQueue and Timer without extra namespace declarations, then confirm both UWP and WinAppSDK/WinUI 3 usage builds successfully.

Vom Indexierungsmodell aus dem Issue-Text verfasst.

Bewertung

Tech-Stack
csharp
Bereich
tooling
Issue-Typ
Bug
Schwierigkeit
1/5
Geschätzter Aufwand
Unter einer Stunde
Aktivitätsstatus
Veraltet
Klarheit
Klar beschrieben
Anfängerfreundlichkeit
42/100

Neue Issues direkt in Ihr Postfach

Eine kurze Übersicht über anfängerfreundliche GitHub-Issues.