CommunityToolkit / CommunityToolkit/Tooling-Windows-Submodule
Sample content constrained to 600px MaxHeight in Normal visual state
- Lingua principale
- C#
- Stelle
- 55
- Fork
- 19
- Merge medio
- 40m
- PR unite (30g)
- 1
Descrizione
## Describe the bug
The sample hosting framework applies a hardcoded MaxHeight constraint of 600 pixels to sample content in the "Normal" visual state. This causes sample content to be artificially cut off when the options pane is taller than the sample content area.
## Steps to reproduce
1. Open the Sample Gallery application
2. Navigate to a sample that uses [ToolkitSampleOptionsPane] with a tall options pane (e.g., MarkdownTextBlock Custom Theme Sample)
3. Observe that the sample content area is constrained to 600px height even when the options pane is significantly taller
4. The sample content appears cut off at the bottom
**Problematic code:** [ToolkitSampleRenderer.xaml#L26](https://github.com/CommunityToolkit/Tooling-Windows-Submodule/blob/main/CommunityToolkit.App.Shared/Renderers/ToolkitSampleRenderer.xaml#L26)
## Expected behavior
MaxHeight should be applied to both the sample content and the sample options pane.
Worth also trying a MinHeight instead to allow it to expand without taking all available height.
## Code Platform
- UWP
- WinAppSDK / WinUI 3
## Device form factor
- Desktop
## Additional context
Found during review of https://github.com/CommunityToolkit/Labs-Windows/pull/761#pullrequestreview-3633778180
Guida per i contributori
Apri la guida per i contributori
Direzione di ricerca
Open CommunityToolkit.App.Shared/Renderers/ToolkitSampleRenderer.xaml at the referenced line and run the Sample Gallery. Reproduce the issue with the MarkdownTextBlock Custom Theme Sample and inspect the Normal visual state alongside its tall options pane. Done means the sample content is not artificially clipped and its height behavior matches the expected options-pane layout.
Scritto dal modello di indicizzazione a partire dal testo della issue.
Valutazione
- Stack tecnologico
- csharp
- Ambito
- frontend
- Tipo di issue
- Bug
- Difficoltà
- 2/5
- Tempo stimato
- 1-3 ore
- Stato di attività
- Ferma
- Chiarezza
- Abbastanza chiara
- Idoneità per principianti
- 55/100