CommunityToolkit / CommunityToolkit/Tooling-Windows-Submodule
Sample content constrained to 600px MaxHeight in Normal visual state
- Lenguaje dominante
- C#
- Estrellas
- 56
- Forks
- 19
- Merge medio
- 40 min
- PR fusionados (30 d)
- 1
Descripción
## Describe the bug
The sample hosting framework applies a hardcoded MaxHeight constraint of 600 pixels to sample content in the "Normal" visual state. This causes sample content to be artificially cut off when the options pane is taller than the sample content area.
## Steps to reproduce
1. Open the Sample Gallery application
2. Navigate to a sample that uses [ToolkitSampleOptionsPane] with a tall options pane (e.g., MarkdownTextBlock Custom Theme Sample)
3. Observe that the sample content area is constrained to 600px height even when the options pane is significantly taller
4. The sample content appears cut off at the bottom
**Problematic code:** [ToolkitSampleRenderer.xaml#L26](https://github.com/CommunityToolkit/Tooling-Windows-Submodule/blob/main/CommunityToolkit.App.Shared/Renderers/ToolkitSampleRenderer.xaml#L26)
## Expected behavior
MaxHeight should be applied to both the sample content and the sample options pane.
Worth also trying a MinHeight instead to allow it to expand without taking all available height.
## Code Platform
- UWP
- WinAppSDK / WinUI 3
## Device form factor
- Desktop
## Additional context
Found during review of https://github.com/CommunityToolkit/Labs-Windows/pull/761#pullrequestreview-3633778180
Guía de contribución
Línea de trabajo
Abre CommunityToolkit.App.Shared/Renderers/ToolkitSampleRenderer.xaml en la línea referenciada y ejecuta la Sample Gallery. Reproduce el problema con el MarkdownTextBlock Custom Theme Sample e inspecciona el estado visual Normal junto con su panel de opciones alto. La tarea estará terminada cuando el contenido del sample no se recorte artificialmente y su comportamiento de altura coincida con el diseño esperado del panel de opciones.
Escrito por el modelo de indexación a partir del texto del issue.
Evaluación
- Stack tecnológico
- csharp
- Área
- frontend
- Tipo de issue
- Error
- Dificultad
- 2/5
- Tiempo estimado
- 1-3 horas
- Estado de actividad
- Estancado
- Claridad
- Bastante claro
- Aptitud para principiantes
- 55/100