CommandCodeAI / CommandCodeAI/command-code

Mod slash commands that open UI require Enter twice from the slash menu

未關閉
#744 0 則留言 0 個 reaction 已指派 0 人 在 GitHub 檢視

還沒有人認領這個 Issue。

主要語言
沒有語言資料
星號
4k
分支
350
PR 合併指標
30 天內沒有已合併 PR

描述

Mod slash commands that open UI require Enter twice from the slash menu

Summary

Selecting a mod-provided slash command from the TUI slash menu requires two Enter presses before its handler runs. The first Enter only inserts the completed command into the input; the second Enter dispatches it. Built-in picker commands such as /model run on the first Enter.

This makes UI-only mod commands feel less integrated and contradicts the slash-command documentation, which says Enter runs the selected command while Tab or Right Arrow inserts it.

Expected behavior

A mod command explicitly marked as action-only / execute-on-select should run its handler on the first Enter, allowing a cmd.ui.select() dialog to open immediately like /model.

Tab and Right Arrow should continue to insert the command for editing without executing it.

Actual behavior

The first Enter completes and inserts the mod command with a trailing space. The handler is only called after a second Enter. There is no public addCommand option that lets a mod opt into the built-in picker behavior.

Minimal reproduction

import type {ModApi} from '@commandcode/harness';

export default function (cmd: ModApi): void {
  cmd.addCommand({
    name: 'picker-test',
    description: 'Open a test picker',
    handler: async () => {
      await cmd.ui.select({
        title: 'Test picker',
        options: [{label: 'One'}, {label: 'Two'}],
      });
    },
  });
}
  1. Start cmd --mod ./picker-test.ts.
  2. Type /picker-test or select it from the slash menu.
  3. Press Enter once.
  4. Observe that the picker does not open and the command is merely inserted.
  5. Press Enter again; the picker opens.
  6. Compare with /model, which opens its picker on the first Enter.

Environment

  • Command Code 1.32.2 (latest npm release at time of report)
  • Linux
  • Bash

Technical analysis

The runtime keeps built-in picker commands such as /model in a private BARE_OPENS_PICKER_BUILTIN_SLASH_COMMANDS set. The input dispatcher bypasses completion for members of that set and invokes them immediately.

Mod command menu items only carry command and description, and the public command registration contract is currently {name, description?, argumentHint?, handler}. Consequently, a mod cannot request the same execution mode. transformInput is not a workaround because slash commands and individual keypresses do not route through it.

Suggested API and implementation

Add an explicit opt-in field, for example:

cmd.addCommand({
  name: 'picker-test',
  description: 'Open a test picker',
  executeOnSelect: true,
  handler: async () => { /* open UI */ },
});

Then:

  1. Preserve executeOnSelect in the mod host's command menu items.
  2. In the slash-menu Enter handler, dispatch such an item immediately.
  3. Keep Tab and Right Arrow as insertion-only actions.
  4. Keep the existing completion behavior as the default for backward compatibility.

Suggested regression coverage:

  • a mod command with executeOnSelect: true runs exactly once on the first Enter;
  • a normal mod command retains its existing completion behavior;
  • Tab and Right Arrow never execute either kind;
  • built-in /model behavior remains unchanged.

Real-world case

command-code-external-providers registers /external-providers, whose handler immediately opens a provider/model picker. It currently needs the extra Enter even though it has no arguments and behaves like a built-in picker command.

貢獻指南

這個儲存庫沒有索引到貢獻指南

從這裡開始

  1. 先讀完整個 Issue,再讀專案的貢獻指南。
  2. 在 Issue 下留言說明你要接手 —— 這能避免兩個人做同樣的事。
  3. Fork 儲存庫,在一個分支上完成修改。
  4. 送出 Pull Request,並在描述裡引用這個 Issue 編號。

研究方向

從 mod 命令註冊契約和 slash-menu 的 Enter 處理器開始,然後追蹤命令和描述如何傳遞到選單項目。新增 opt-in 執行狀態,同時保留 Tab 和 Right Arrow 上的插入行為。驗證列出的回歸案例,包括第一次按 Enter 時執行、正常的命令補全,以及 /model 行為不變。

由索引模型根據 Issue 內容生成。

評估

技術堆疊
typescript
領域
api, cli, testing-qa
Issue 類型
缺陷
難度
4/5
預估耗時
3-5 天
活躍度
活躍
描述清晰度
描述清楚
新手友好度
72/100

把新 issue 寄到你的電子郵件信箱

精選適合新手參與的 GitHub issue 摘要。