CommandCodeAI / CommandCodeAI/command-code
Mod slash commands that open UI require Enter twice from the slash menu
Nessuno ha ancora preso questa issue.
- Lingua principale
- Nessun dato sulla lingua
- Stelle
- 4k
- Fork
- 350
- Metriche di merge delle PR
- Nessuna PR unita negli ultimi 30g
Descrizione
Mod slash commands that open UI require Enter twice from the slash menu
Summary
Selecting a mod-provided slash command from the TUI slash menu requires two Enter presses before its handler runs. The first Enter only inserts the completed command into the input; the second Enter dispatches it. Built-in picker commands such as /model run on the first Enter.
This makes UI-only mod commands feel less integrated and contradicts the slash-command documentation, which says Enter runs the selected command while Tab or Right Arrow inserts it.
Expected behavior
A mod command explicitly marked as action-only / execute-on-select should run its handler on the first Enter, allowing a cmd.ui.select() dialog to open immediately like /model.
Tab and Right Arrow should continue to insert the command for editing without executing it.
Actual behavior
The first Enter completes and inserts the mod command with a trailing space. The handler is only called after a second Enter. There is no public addCommand option that lets a mod opt into the built-in picker behavior.
Minimal reproduction
import type {ModApi} from '@commandcode/harness';
export default function (cmd: ModApi): void {
cmd.addCommand({
name: 'picker-test',
description: 'Open a test picker',
handler: async () => {
await cmd.ui.select({
title: 'Test picker',
options: [{label: 'One'}, {label: 'Two'}],
});
},
});
}
- Start
cmd --mod ./picker-test.ts. - Type
/picker-testor select it from the slash menu. - Press Enter once.
- Observe that the picker does not open and the command is merely inserted.
- Press Enter again; the picker opens.
- Compare with
/model, which opens its picker on the first Enter.
Environment
- Command Code 1.32.2 (latest npm release at time of report)
- Linux
- Bash
Technical analysis
The runtime keeps built-in picker commands such as /model in a private BARE_OPENS_PICKER_BUILTIN_SLASH_COMMANDS set. The input dispatcher bypasses completion for members of that set and invokes them immediately.
Mod command menu items only carry command and description, and the public command registration contract is currently {name, description?, argumentHint?, handler}. Consequently, a mod cannot request the same execution mode. transformInput is not a workaround because slash commands and individual keypresses do not route through it.
Suggested API and implementation
Add an explicit opt-in field, for example:
cmd.addCommand({
name: 'picker-test',
description: 'Open a test picker',
executeOnSelect: true,
handler: async () => { /* open UI */ },
});
Then:
- Preserve
executeOnSelectin the mod host's command menu items. - In the slash-menu Enter handler, dispatch such an item immediately.
- Keep Tab and Right Arrow as insertion-only actions.
- Keep the existing completion behavior as the default for backward compatibility.
Suggested regression coverage:
- a mod command with
executeOnSelect: trueruns exactly once on the first Enter; - a normal mod command retains its existing completion behavior;
- Tab and Right Arrow never execute either kind;
- built-in
/modelbehavior remains unchanged.
Real-world case
command-code-external-providers registers /external-providers, whose handler immediately opens a provider/model picker. It currently needs the extra Enter even though it has no arguments and behaves like a built-in picker command.
Guida per i contributori
Nessuna guida per i contributori indicizzata per questo repository
Come iniziare
- Leggi tutta la issue e poi la guida ai contributi del progetto.
- Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
- Fai un fork del repository e lavora su un branch.
- Apri una pull request che faccia riferimento al numero della issue.
Direzione di ricerca
Inizia con il contratto di registrazione dei comandi mod e l’handler di Enter di slash-menu, quindi segui il percorso di comando e descrizione fino agli elementi del menu. Aggiungi lo stato di esecuzione opt-in, preservando l’inserimento con Tab e Right Arrow. Verifica i casi di regressione elencati, inclusi l’esecuzione al primo Enter, il normale completamento dei comandi e il comportamento invariato di /model.
Scritto dal modello di indicizzazione a partire dal testo della issue.
Valutazione
- Stack tecnologico
- typescript
- Ambito
- api, cli, testing-qa
- Tipo di issue
- Bug
- Difficoltà
- 4/5
- Tempo stimato
- 3-5 giorni
- Stato di attività
- Attiva
- Chiarezza
- Specificata chiaramente
- Idoneità per principianti
- 72/100