CodingTrain / CodingTrain/12oclocks
Clock 8 sizing and positioning
- Lingua principale
- JavaScript
- Stelle
- 27
- Fork
- 26
- Metriche di merge delle PR
- Nessuna PR unita negli ultimi 30g
Descrizione
Clock 8 seems to have a lot of incorrect measurements. First of all the scaling center point of a two digit number, for instance the minutes, seem to be in the second digit. This makes that it is scaling to the left, which the original doesn't do.
It can be clearly seen in these two screenshots
### Measurements on the remake of clock 8


As you can see the number 7 is the number staying on the red line.
Also the positioning currently is 1/4 of the width from the left and the right (again here a two digit numbers' center is incorrect). I tried measuring the locations of the original clock but could not come to precise fractions so I'm not sure how the positions were originally determined. However we can at least take an estimate to more accurately represent it.
Here is the original.
### Measurements on the original clock 8


Notice how the single digit is positioned more to the right, and the right number is scaling from it's center.
Lastly the size it increases and decreases to also currently is not relative to the screen size. You can clearly see this when enlarging the clock by clicking on it (it will show very tiny numbers). The measurements I took of the two heights again seems non-logical, but I guess it is the only way we can most accurately reproduce the original.
### Measurement on the original clock 8's height

If anyone wants to implement these numbers or have a (maybe better) look themselves? I just wanted to point these things out and hope if I ever do make these changes myself people won't think I'm crazy for the these weird numbers.
Guida per i contributori
Nessuna guida per i contributori indicizzata per questo repository
Direzione di ricerca
Inizia dall’implementazione di Clock 8 e riproduci il comportamento di dimensionamento e posizionamento facendo clic sull’orologio per ingrandirlo, quindi confronta il risultato con gli screenshot forniti del remake e dell’originale. Il lavoro è completato quando i valori a due cifre vengono ridimensionati dal centro corretto, i valori a una e due cifre sono posizionati accuratamente e il ridimensionamento rimane relativo alle dimensioni dello schermo.
Scritto dal modello di indicizzazione a partire dal testo della issue.
Valutazione
- Stack tecnologico
- javascript
- Ambito
- frontend
- Tipo di issue
- Bug
- Difficoltà
- 4/5
- Tempo stimato
- 3-5 giorni
- Stato di attività
- Ferma
- Chiarezza
- Abbastanza chiara
- Idoneità per principianti
- 35/100