CodingTrain / CodingTrain/12oclocks
Clock 8 sizing and positioning
- Vorherrschende Sprache
- JavaScript
- Sterne
- 27
- Forks
- 26
- PR-Merge-Kennzahlen
- Keine gemergten PRs in 30 T.
Beschreibung
Clock 8 seems to have a lot of incorrect measurements. First of all the scaling center point of a two digit number, for instance the minutes, seem to be in the second digit. This makes that it is scaling to the left, which the original doesn't do.
It can be clearly seen in these two screenshots
### Measurements on the remake of clock 8


As you can see the number 7 is the number staying on the red line.
Also the positioning currently is 1/4 of the width from the left and the right (again here a two digit numbers' center is incorrect). I tried measuring the locations of the original clock but could not come to precise fractions so I'm not sure how the positions were originally determined. However we can at least take an estimate to more accurately represent it.
Here is the original.
### Measurements on the original clock 8


Notice how the single digit is positioned more to the right, and the right number is scaling from it's center.
Lastly the size it increases and decreases to also currently is not relative to the screen size. You can clearly see this when enlarging the clock by clicking on it (it will show very tiny numbers). The measurements I took of the two heights again seems non-logical, but I guess it is the only way we can most accurately reproduce the original.
### Measurement on the original clock 8's height

If anyone wants to implement these numbers or have a (maybe better) look themselves? I just wanted to point these things out and hope if I ever do make these changes myself people won't think I'm crazy for the these weird numbers.
Beitragsleitfaden
Für dieses Repository ist kein Beitragsleitfaden indexiert
Rechercherichtung
Beginne mit der Clock 8-Implementierung und reproduziere das Größen- und Positionierungsverhalten, indem du auf die Uhr klickst, um sie zu vergrößern, und vergleiche anschließend das Ergebnis mit den bereitgestellten Screenshots des Remakes und des Originals. Als abgeschlossen gilt die Aufgabe, wenn zweistellige Werte vom korrekten Mittelpunkt aus skaliert werden, ein- und zweistellige Werte genau positioniert sind und die Größenänderung relativ zur Bildschirmgröße bleibt.
Vom Indexierungsmodell aus dem Issue-Text verfasst.
Bewertung
- Tech-Stack
- javascript
- Bereich
- frontend
- Issue-Typ
- Bug
- Schwierigkeit
- 4/5
- Geschätzter Aufwand
- 3-5 Tage
- Aktivitätsstatus
- Veraltet
- Klarheit
- Größtenteils klar
- Anfängerfreundlichkeit
- 35/100